Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pallet xcm interface precompile #966

Merged
merged 13 commits into from
Aug 21, 2024
Merged

Conversation

wuzhong-papermoon
Copy link
Contributor

Description

Adding XCM interface precompile

Checklist

  • [ ✔️] I have added a label to this PR 🏷️
  • [ ✔️] I have run my changes through Grammarly
  • [ ✔️] If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • [ ✔️] If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • [ ✔️] If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • [ ✔️] After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • [ ✔️] If images have been added, I have run the compress-images.py script to compress the images.
  • [ ✔️] If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • [ ✔️] If this page requires a disclaimer, I have added one

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove variables
  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

XCM interface .sol is not really published in [moonbeam precompiles github registry](https://github.com/moonbeam-foundation/moonbeam/tree/master/precompiles)
Needs to check if the folder structure is correct
Change variable value of precompile address to: 0x000000000000000000000000000000000000081A
which was tested for moonbase Alpha
@wuzhong-papermoon wuzhong-papermoon added the A0 - New Content Pull request contains new content pages label Jul 31, 2024
@wuzhong-papermoon
Copy link
Contributor Author

@eshaben Could you check if the file structure is correct?

Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a couple things I found!

builders/ethereum/precompiles/interoperability/.pages Outdated Show resolved Hide resolved
builders/precompiles/xcm-Interface.md Outdated Show resolved Hide resolved
builders/precompiles/xcm-Interface.md Outdated Show resolved Hide resolved
builders/precompiles/xcm-Interface.md Outdated Show resolved Hide resolved
builders/precompiles/xcm-Interface.md Outdated Show resolved Hide resolved
builders/ethereum/precompiles/overview.md Show resolved Hide resolved
builders/ethereum/precompiles/overview.md Outdated Show resolved Hide resolved
builders/ethereum/precompiles/overview.md Show resolved Hide resolved
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some comments on the images:

  • The style guide mentions that arrows should not be used with steps. So you can remove the arrows anywhere you're using steps.
  • Are the steps 24x24px? This is also outlined in the style guide if you need more info
  • On xcm-interface-2.webp the steps appear to be larger than they are on xcm-interface-3.webp - can you tell me what size the steps are on 3? I can help you make some decisions here because I realize the size might need to change since they're so close together

As for the structure and where to put things, let me get back to you on this. But it will definitely need to be moved to the Interoperability > XCM section. I'll let you know where exactly!

builders/precompiles/xcm-Interface.md Outdated Show resolved Hide resolved
builders/precompiles/xcm-Interface.md Outdated Show resolved Hide resolved
@wuzhong-papermoon
Copy link
Contributor Author

Looks good! Just some comments on the images:

  • The style guide mentions that arrows should not be used with steps. So you can remove the arrows anywhere you're using steps.
  • Are the steps 24x24px? This is also outlined in the style guide if you need more info
  • On xcm-interface-2.webp the steps appear to be larger than they are on xcm-interface-3.webp - can you tell me what size the steps are on 3? I can help you make some decisions here because I realize the size might need to change since they're so close together

As for the structure and where to put things, let me get back to you on this. But it will definitely need to be moved to the Interoperability > XCM section. I'll let you know where exactly!

Ah sorry that I didn't use standard style for steps. It should be all set now. 24x24 might be alright, would you take a look at the new images? @eshaben

@eshaben
Copy link
Contributor

eshaben commented Aug 13, 2024

@wuzhong-papermoon yes, images look better! thanks!

Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @themacexpert just up to you to review/approve now 🙂

@themacexpert themacexpert self-requested a review August 21, 2024 17:31
@eshaben eshaben merged commit 15759dc into master Aug 21, 2024
1 check passed
@eshaben eshaben deleted the adding-pallet-XCM-precompile branch August 21, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0 - New Content Pull request contains new content pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants