-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pallet xcm interface precompile #966
Conversation
XCM interface .sol is not really published in [moonbeam precompiles github registry](https://github.com/moonbeam-foundation/moonbeam/tree/master/precompiles)
Needs to check if the folder structure is correct
Change variable value of precompile address to: 0x000000000000000000000000000000000000081A which was tested for moonbase Alpha
@eshaben Could you check if the file structure is correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just a couple things I found!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some comments on the images:
- The style guide mentions that arrows should not be used with steps. So you can remove the arrows anywhere you're using steps.
- Are the steps 24x24px? This is also outlined in the style guide if you need more info
- On
xcm-interface-2.webp
the steps appear to be larger than they are onxcm-interface-3.webp
- can you tell me what size the steps are on 3? I can help you make some decisions here because I realize the size might need to change since they're so close together
As for the structure and where to put things, let me get back to you on this. But it will definitely need to be moved to the Interoperability > XCM section. I'll let you know where exactly!
Ah sorry that I didn't use standard style for steps. It should be all set now. 24x24 might be alright, would you take a look at the new images? @eshaben |
@wuzhong-papermoon yes, images look better! thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @themacexpert just up to you to review/approve now 🙂
Description
Adding XCM interface precompile
Checklist
moonbeam-docs-cn
repo, I have created a ticket for the translations in Jiramoonbeam-mkdocs
to update redirectsmove-pages.py
script to move the pages and update the image paths on the chinese repomoonbeam-docs-cn
compress-images.py
script to compress the images.moonbeam-docs-cn
repo to use the new variablesCorresponding PRs
Please link to any corresponding PRs here.
After Translation Requirements
moonbeam-docs
repo to remove imagesmoonbeam-docs
repo to remove variablesmoonbeam-mkdocs
repo to add redirects for Chinese siteItems to be Updated
Please list any of the items that will need to be added or deleted after the translations are done here.