Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates spec_version for moonbase, updates runtime upgrades by block … #967

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

dawnkelly09
Copy link
Contributor

…page to add 3100 to moonbase

Description

  • Updates spec_version variable in variables.yml file for moonbase
  • Checked for code snippets dependent upon moonbase.spec_version and they seem to all render correctly after variable update
  • Updates runtime upgrades by block page to add 3100 block info for moonbase

I will create a separate PR to update the docs-test-suite repo re: runtime upgrade test

Checklist

  • [x ] I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • If images have been added, I have run the compress-images.py script to compress the images.
  • If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • If this page requires a disclaimer, I have added one

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove variables
  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@dawnkelly09 dawnkelly09 added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Jul 31, 2024
@dawnkelly09 dawnkelly09 requested a review from eshaben July 31, 2024 15:32
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you double-check the links that use the moonbase.spec_version variable? Most of these links reference a specific line in the code that is subject to change as each runtime version is rolled out. So to keep our links pointing at the correct line of code, we need to double-check the links and update the lines. Usually there is like one or two places that always needs to be updated, so just want to make sure that wasn't missed

variables.yml Outdated Show resolved Hide resolved
builders/build/runtime-upgrades.md Outdated Show resolved Hide resolved
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just one more thing!

builders/build/runtime-upgrades.md Outdated Show resolved Hide resolved
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@eshaben eshaben merged commit 6a8af13 into master Aug 5, 2024
1 check passed
@eshaben eshaben deleted the dawn/update-moonbase-spec-runtime branch August 5, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants