Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade substrate to v0.9.37 #2072

Merged
merged 22 commits into from
Feb 13, 2023
Merged

upgrade substrate to v0.9.37 #2072

merged 22 commits into from
Feb 13, 2023

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Feb 3, 2023 •
edited
Loading

What does it do?

upgrades moonbeam to v0.9.37

Notes

Substrate

Pallet Assets

Inherents

Others

Polkadot

Cumulus

Nimbus

Frontier

Refactor BlockId::Number in favor of BlockId::Hash

paritytech/polkadot-sdk#53

Others

Moonbeam

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@nbaztec nbaztec added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited breaking Needs to be mentioned in breaking changes labels Feb 6, 2023
@nbaztec nbaztec marked this pull request as ready for review February 9, 2023 09:01
notlesh
notlesh approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@notlesh notlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm somewhere between pleasantly surprised and skeptical that our Frontier patches are so minimal...

@tgmichel tgmichel added the A10-evmtracing Pull request includes evm tracing functionality label Feb 10, 2023
@tgmichel tgmichel mentioned this pull request Feb 10, 2023
Closed
tgmichel
tgmichel reviewed Feb 10, 2023
View reviewed changes
precompiles/batch/src/tests.rs Show resolved Hide resolved
precompiles/batch/src/tests.rs Show resolved Hide resolved
runtime/moonbeam/src/lib.rs Show resolved Hide resolved
runtime/moonbeam/src/lib.rs
@@ -1211,6 +1216,7 @@ construct_runtime! {
RandomnessCollectiveFlip: pallet_randomness_collective_flip::{Pallet, Storage} = 2,
Timestamp: pallet_timestamp::{Pallet, Call, Storage, Inherent} = 3,
ParachainInfo: parachain_info::{Pallet, Storage, Config} = 4,
RootTesting: pallet_root_testing::{Pallet, Call, Storage} = 5,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we positive index 5 was never used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I can move it to end of line just to be safe. @notlesh opinions?

@crystalin
Copy link
Collaborator

--sealing manual doesn't work because it uses the wrong parent hash it seems:
image

This was referenced Feb 11, 2023
Merged
Merged
@nbaztec nbaztec merged commit 4c22f7c into master Feb 13, 2023
@nbaztec nbaztec deleted the upgrade-v0.9.37 branch February 13, 2023 14:54
@crystalin
Copy link
Collaborator

🥇

@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Feb 14, 2023
@notlesh notlesh added D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Feb 22, 2023
@crystalin crystalin changed the title upgrade to v0.9.37 upgrade substrate to v0.9.37 Feb 22, 2023
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
@nbaztec @tgmichel @imstar15
upgrade to v0.9.37 (moonbeam-foundation#2072)
3c36763 
* upgrade to v0.9.37

* fix tests

* update frontier

* fix tests

* add root-testing pallet

* add call_index

* Fix tracing reference hash

---------

Co-authored-by: tgmichel <telmo@purestake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgmichel tgmichel tgmichel left review comments

@notlesh notlesh notlesh approved these changes

Assignees
No one assigned
Labels
A10-evmtracing Pull request includes evm tracing functionality B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nbaztec @crystalin @notlesh @tgmichel