-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix warnings #2832
Merged
fix warnings #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B0-silent
Changes should not be mentioned in any release notes
D3-trivial
PR contains trivial changes in a runtime directory that do not require an audit
labels
May 31, 2024
RomarQ
requested review from
noandrea and
ahmadkaouk
and removed request for
a team
May 31, 2024 10:14
Coverage Report@@ Coverage Diff @@
## master rq/fix_ci +/- ##
=============================================
- Coverage 72.88% 72.87% -0.01%
Files 229 229
+ Lines 70024 70026 +2
=============================================
Hits 51031 51031
+ Misses 18993 18995 +2
|
This reverts commit 23bb3be.
RomarQ
requested review from
librelois and
Agusrodri
and removed request for
a team
May 31, 2024 16:00
ahmadkaouk
approved these changes
Jun 3, 2024
RomarQ
added a commit
that referenced
this pull request
Jun 25, 2024
* fix: explicitly drop returned value * fix: log DispatchError * update cargo.lock * fix warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B0-silent
Changes should not be mentioned in any release notes
D3-trivial
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes some warnings related to
unused implementer
and false positive occurrences ofunused code
.rust-lang/rust#121708