Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings #2832

Merged
merged 7 commits into from
Jun 3, 2024
Merged

fix warnings #2832

merged 7 commits into from
Jun 3, 2024

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented May 31, 2024

What does it do?

Fixes some warnings related to unused implementer and false positive occurrences of unused code.
rust-lang/rust#121708

@RomarQ RomarQ added B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels May 31, 2024
@RomarQ RomarQ requested a review from a team May 31, 2024 10:14
@RomarQ RomarQ self-assigned this May 31, 2024
@RomarQ RomarQ requested review from noandrea and ahmadkaouk and removed request for a team May 31, 2024 10:14
Copy link
Contributor

github-actions bot commented May 31, 2024

Coverage Report

@@              Coverage Diff              @@
##           master   rq/fix_ci      +/-   ##
=============================================
- Coverage   72.88%      72.87%   -0.01%     
  Files         229         229              
+ Lines       70024       70026       +2     
=============================================
  Hits        51031       51031              
+ Misses      18993       18995       +2     
Files Changed Coverage

Coverage generated Fri May 31 21:02:37 UTC 2024

@RomarQ RomarQ requested review from a team as code owners May 31, 2024 15:21
@RomarQ RomarQ changed the title fix: explicitly drop returned value fix warnings May 31, 2024
@RomarQ RomarQ requested review from librelois and Agusrodri and removed request for a team May 31, 2024 16:00
@RomarQ RomarQ merged commit bef2485 into master Jun 3, 2024
27 checks passed
@RomarQ RomarQ deleted the rq/fix_ci branch June 3, 2024 08:02
RomarQ added a commit that referenced this pull request Jun 25, 2024
* fix: explicitly drop returned value

* fix: log DispatchError

* update cargo.lock

* fix warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants