Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added V2 to xcmPallet limitedReservedTransferAssets #61

Merged
merged 7 commits into from
Feb 23, 2023
Merged

Added V2 to xcmPallet limitedReservedTransferAssets #61

merged 7 commits into from
Feb 23, 2023

Conversation

fgamundi
Copy link
Contributor

@fgamundi fgamundi commented Feb 22, 2023 •
edited
Loading

Description

Please explain the changes this PR addresses here.

Checklist

  • If this requires a documentation change, I have created a PR in moonbeam-docs repository.
  • If this requires it, I have updated the Readme
  • If necessary, I have updated the examples
  • I have verified if I need to create/update unit tests
  • I have verified if I need to create/update acceptance tests
  • If necessary, I have run acceptance tests on this branch in CI

@fgamundi fgamundi marked this pull request as ready for review February 22, 2023 22:32
@fgamundi fgamundi changed the title Added V2 to PolkadotXCM limitedReservedTransferAssets Added V2 to xcmPallet limitedReservedTransferAssets Feb 22, 2023
ekenigs
ekenigs previously approved these changes Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@ekenigs ekenigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few small things.

packages/config/src/extrinsic/xcmPallet/xcmPallet.test.ts Outdated Show resolved Hide resolved
packages/config/src/extrinsic/xcmPallet/xcmPallet.test.ts Outdated Show resolved Hide resolved
@fgamundi
Update packages/config/src/extrinsic/xcmPallet/xcmPallet.test.ts
3930a89 
Co-authored-by: Elmar Kenigs <elmar@purestake.com>
@fgamundi fgamundi merged commit f67926b into main Feb 23, 2023
@fgamundi fgamundi deleted the fxg/polkadotxcm-v2 branch February 23, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekenigs ekenigs ekenigs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgamundi @ekenigs