remove duplicated impl in builtin and other packages

[Guest0x0]

There are duplicated impl of Hash::hash_combine for types Bytes, Int64, Double, Bool and Unit, in builtin package and their own package. This PR removes duplicated impl in builtin package.

The compiler should be responsible for report error on such duplicated impl, so there is also a compiler bug involved here that should be fixed.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[peter-jerry-ye-code-review]

Based on the provided git diff output, here are three potential issues or suggestions for improvement in the MoonBit code:

1. Redundant Impl Blocks:

   • The diff shows that several impl Hash for blocks have been removed. Specifically, Hash for Unit, Hash for Bool, Hash for Int64, Hash for Double, and Hash for Bytes have been commented out or removed. This might indicate that these implementations were redundant or unnecessary. Ensure that removing these implementations does not affect the expected behavior of the Hash trait across different data types.

2. Consistency in Impl Blocks:

   • It seems that the Hash trait implementation for Int and UInt directly calls hash_combine with the hasher, while other implementations like String do the same. Ensure that all relevant data types follow this consistent approach to avoid confusion and maintain a standard pattern across the codebase.

3. Documentation and Comments:

   • The diff shows changes in the Hash trait implementations, but there are no comments explaining why these changes are necessary or beneficial. Adding clear and concise comments explaining the purpose of the changes, especially when removing or modifying trait implementations, can help other developers understand the rationale behind the changes and maintain the code more effectively.

Overall, the changes indicate a potential cleanup or refinement of the Hash trait implementations. It's important to ensure that these changes do not introduce bugs or inconsistencies and to document any significant modifications for future reference.

[coveralls]

Pull Request Test Coverage Report for Build 3241

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.09%) to 83.163%

---

Totals
Change from base Build 3236:	0.09%
Covered Lines:	4075
Relevant Lines:	4900

---

💛 - Coveralls