Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start preparing build-runtime job #127

Merged
merged 49 commits into from
Jun 22, 2023
Merged

start preparing build-runtime job #127

merged 49 commits into from
Jun 22, 2023

Conversation

girazoki
Copy link
Collaborator

@girazoki girazoki commented Jun 19, 2023

Adds a CI job able to publish the runtime release on request, giving the previous tag name and the new one

@girazoki girazoki marked this pull request as ready for review June 21, 2023 12:25
@girazoki girazoki requested a review from tmpolaczyk June 21, 2023 12:26
@tmpolaczyk
Copy link
Contributor

In the tests/ dir we don't commit package-lock.json, we commit the pnpm-lock.yaml created by pnpm. So maybe it is worth it to also use pnpm here?

@girazoki
Copy link
Collaborator Author

I can check it out

@girazoki girazoki requested a review from crystalin June 21, 2023 14:03
@girazoki
Copy link
Collaborator Author

I tried pnpm but failed. Will try in a future pr, for now I will leave yarn

####### Build runtimes with srtool #######

setup-scripts:
runs-on: self-hosted
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing to use label instead of generic self-hosted will be easier for maintenance

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we have an issue for that already. But will do a PR changing all those at once.

.github/workflows/publish-runtime.yml Show resolved Hide resolved
.github/workflows/publish-runtime.yml Show resolved Hide resolved
Base automatically changed from girazoki-dancebox-introduction to master June 22, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants