Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polkadot v1.6.0 upgrade #413

Merged
merged 49 commits into from
Feb 22, 2024
Merged

Polkadot v1.6.0 upgrade #413

merged 49 commits into from
Feb 22, 2024

Conversation

fgamundi
Copy link
Contributor

@fgamundi fgamundi commented Feb 14, 2024 •
edited
Loading

Upgrades polkadot-sdk dependencies to v1.6.0

Some relevant PRs
paritytech/polkadot-sdk#1256 chain-spec: getting ready for native-runtime-free world
paritytech/polkadot-sdk#1246 DmpQueue & XcmpQueue transition to MessageQueue
paritytech/polkadot-sdk#2048 & paritytech/polkadot-sdk#2651 Identity pallet improvements
paritytech/polkadot-sdk#2803 cumulus-primitives-parachain-inherent split
paritytech/polkadot-sdk#2331 ExportGenesisStateCommand to ExportGenesisHeadCommand
paritytech/polkadot-sdk#2834 proposer: return optional block
paritytech/polkadot-sdk#1343 RuntimeTask
paritytech/polkadot-sdk#2767 PartialComponents

tmpolaczyk
tmpolaczyk reviewed Feb 16, 2024
View reviewed changes
node/src/cli.rs Outdated Show resolved Hide resolved
@fgamundi fgamundi self-assigned this Feb 16, 2024
@fgamundi fgamundi added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes labels Feb 16, 2024
@tmpolaczyk tmpolaczyk mentioned this pull request Feb 16, 2024
Closed
girazoki
girazoki reviewed Feb 19, 2024
View reviewed changes
client/consensus/src/collators/basic.rs
collation,
result_sender,
}));
if let Some((collation, _, post_hash)) = maybe_collation {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn it, I hate that they keep changing this part of the code

@girazoki girazoki marked this pull request as ready for review February 21, 2024 10:48
girazoki
girazoki approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@girazoki girazoki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job @fgamundi ! But please remember to point to the right branch instead of the one with 'preview'

@fgamundi
Copy link
Contributor Author

fgamundi commented Feb 22, 2024 •
edited
Loading

@girazoki done, and thanks! Also, is there a way to print the coverage report again?

@fgamundi fgamundi merged commit c427348 into master Feb 22, 2024
31 checks passed
@fgamundi fgamundi deleted the fg/polkadot-v1.6.0 branch February 22, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Agusrodri Agusrodri Agusrodri approved these changes

@tmpolaczyk tmpolaczyk tmpolaczyk approved these changes

@girazoki girazoki girazoki approved these changes

@nanocryk nanocryk Awaiting requested review from nanocryk

Assignees

@fgamundi fgamundi

Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fgamundi @girazoki @tmpolaczyk @Agusrodri