Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethereum RPC Data Providers #680

Merged
merged 22 commits into from
Oct 8, 2024
Merged

Ethereum RPC Data Providers #680

merged 22 commits into from
Oct 8, 2024

Conversation

nanocryk
Copy link
Contributor

Makes the spawning logic generic over the RuntimeApi, which allows to inject a GenerateRpcBuilder that can call runtime apis only present in specific runtimes (different in simple and frontier templates).

tmpolaczyk
tmpolaczyk reviewed Sep 13, 2024
View reviewed changes
rust-toolchain Outdated Show resolved Hide resolved
@nanocryk nanocryk marked this pull request as ready for review October 4, 2024 10:37
@nanocryk nanocryk added a0-pleasereview Pull request needs code review. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes labels Oct 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024 •
edited
Loading

Coverage Report

(master)

@@                           Coverage Diff                           @@
##           master   jeremy-spawner-support-ethereum-rpc      +/-   ##
=======================================================================
- Coverage   65.29%                                64.97%   -0.32%     
  Files         296                                   296              
+ Lines       51468                                 51742     +274     
=======================================================================
+ Hits        33605                                 33615      +10     
+ Misses      17863                                 18127     +264
Files Changed Coverage
/client/node-common/src/service.rs 48.08% (-0.23%) ❗
/client/service-container-chain/src/service.rs 6.99% (+0.29%) ✅
/client/service-container-chain/src/spawner.rs 44.44% (-0.22%) ❗
/container-chains/nodes/frontier/src/cli.rs 66.67% (-6.66%) ❗
/container-chains/nodes/frontier/src/command.rs 18.73% (-6.83%) ❗
/container-chains/nodes/frontier/src/rpc/mod.rs 68.50% (-21.27%) ❗
/container-chains/nodes/simple/src/command.rs 18.56% (-0.25%) ❗
/node/src/service.rs 15.56% (-0.09%) ❗

Coverage generated Tue Oct 8 13:09:21 UTC 2024

girazoki
girazoki approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job @nanocryk

@nanocryk nanocryk merged commit 70b3f03 into master Oct 8, 2024
39 checks passed
@nanocryk nanocryk deleted the jeremy-spawner-support-ethereum-rpc branch October 8, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParthDesai ParthDesai ParthDesai left review comments

@tmpolaczyk tmpolaczyk tmpolaczyk approved these changes

@girazoki girazoki girazoki approved these changes

Assignees
No one assigned
Labels
a0-pleasereview Pull request needs code review. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nanocryk @ParthDesai @girazoki @tmpolaczyk