-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BEEFY Testing #724
Merged
Merged
BEEFY Testing #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agusrodri
added
B0-silent
Changes should not be mentioned in any release notes
D2-notlive
PR doesn't change runtime/client code
not-breaking
Does not need to be mentioned in breaking changes
labels
Oct 19, 2024
WASM runtime size check:Compared to target branchdancebox runtime: 1416 KB (no changes) ✅ flashbox runtime: 832 KB (no changes) ✅ dancelight runtime: 1980 KB (+1980 KB) container chain template simple runtime: 1096 KB (-4212 KB) ✅ container chain template frontier runtime: 1392 KB (-5132 KB) ✅ |
Coverage Report@@ Coverage Diff @@
## master agustin-test-beefy +/- ##
======================================================
+ Coverage 64.98% 65.25% +0.27%
+ Files 299 300 +1
+ Lines 52269 52639 +370
======================================================
+ Hits 33964 34348 +384
- Misses 18305 18291 -14
|
girazoki
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B0-silent
Changes should not be mentioned in any release notes
D2-notlive
PR doesn't change runtime/client code
not-breaking
Does not need to be mentioned in breaking changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR adds overall testing around BEEFY protocol.
More specifically, some tests were added to cover the following general scenarios:
Note for reviewers
It was needed to push this commit to Moondance's
polkadot-sdk
fork, given that the previous weight hint forreport_future_block_voting
extrinsic was wrong. This was making the related TS test to fail (as the default weight forreport_fork_voting
isWeight::MAX
).We will not need to cherry-pick that commit in the next dependency upgrade, as the changes are already included in paritytech/polkadot-sdk#5188 for
stable-2409
. I didn't cherry-pick the full changes as I don't want to cause extra unnecessary conflicts before the next dependency upgrade.