Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed deferred replies. #29

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Removed deferred replies. #29

merged 6 commits into from
Nov 20, 2024

Conversation

moonstar-x
Copy link
Owner

📝 Checklist

Make sure that your PR fulfills these requirements:

  • Tests have been added for this feature.
  • All tests pass on your local machine.
  • Code has been linted with the proper rules.
  • Project builds on your local machine.

📄 Description

  • Removed reply deferral because it's no longer needed in current deployment.
  • Fixed a bug where the get offers command would throw if no offers existed for a given provider.
  • Updated tests to reach 100% coverage.

📌 Does this PR address any issue?

#28

@moonstar-x moonstar-x merged commit 0d0ea2d into main Nov 20, 2024
1 check passed
@moonstar-x moonstar-x deleted the defer-removal branch November 20, 2024 22:04
@moonstar-x moonstar-x mentioned this pull request Nov 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@moonstar-x