Adding ERC721 support to dropper. The tokenId of the drop is ignored.… #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Claims should be signed with the tokenId as the amount.
zomglings
requested changes
May 31, 2023
There was a problem hiding this comment.
@kellan-simiotics : Some additions and clarifications requested.
And test for Dropper that check that: - A smart contract can claim ERC721 drops provided it implements `onERC721Received` correctly - A smart contract which does not implement `onERC721Received` cannot claim ERC721 drops TODO(kellan-simiotics): Please add tests for the claimant proxy contracts (especially that they respect ownership for drain). And tests that smart contracts can claim other drop types if they implement the correct interfaces. And that they cannot if they do not.
… and erc20 drops with claimant contracts.
|
@zomglings I believe all of your requested changes are addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Claims should be signed with the tokenId as the amount.
Changes
How to test these changes?
Related issues