Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved dropper_gogogo #325

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

zomglings
Copy link
Collaborator

It can now use existing addresses for any of the facets it mounts to the Diamond contract.

Also updated the CLI to take optional facet address arguments for each facet, as well as contract verification flag.

It can now use existing addresses for any of the facets it mounts to the
Diamond contract.

Also updated the CLI to take optional facet address arguments for each
facet, as well as contract verification flag.
Copy link
Contributor

@kellan-simiotics kellan-simiotics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg - wasn't immediately obvious to me how the non-facet optional addresses were handled until I saw that the behavior of diamond_gogogo was the same. Might be worth a comment.

@zomglings zomglings merged commit 247bb78 into main Aug 3, 2023
@zomglings zomglings deleted the cli-dropper-deployment-improvements branch August 3, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants