Implementation of StatBlock
#328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And emitting events in `StatBlock`.
`batchGetStats` with `getStats`
using both `assignStats` and `batchAssignStats`.
kellan-simiotics
requested changes
Aug 14, 2023
|
TODO(zomglings):
|
`StatCreated` event now only reports `statID`, no longer contains `descriptor` argument. Added `StatDescriptorUpdated` argument which reports `statID` and new `descriptor`. Added tests for access control.
... and implemented it as a public string on `StatBlock`. Also added `setStatDescriptor` to `IStatBlock`. This was already implemented previously on `StatBlock`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
StatBlockcontract andIStatBlockinterface. Includes several tests forStatBlock.StatBlockis implemented here as a standalone contract, not as an EIP2535 facet. In the future, we may add an EIP2535 facet implementation which would support the use ofStatBlockwith proxies.Resolves #317