Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminus migration #334

Merged
merged 13 commits into from
Aug 21, 2023
Merged

Terminus migration #334

merged 13 commits into from
Aug 21, 2023

Conversation

zomglings
Copy link
Collaborator

Migrates Terminus and all related contracts from https://github.com/bugout-dev/dao to this repository.

Partially resolves #316

@zomglings zomglings marked this pull request as ready for review August 21, 2023 00:51
@zomglings
Copy link
Collaborator Author

zomglings commented Aug 21, 2023 •
edited
Loading

TODO:

  • Move smart contracts from https://github.com/bugout-dev/dao
  • Update MockTerminus to use local Terminus implementation
  • Remove Brownie dependencies on old repository
  • Generate Python files for Terminus-related contracts
  • Add terminus-gogogo
  • Move Terminus-related tests into this repository and make sure they pass
  • Generate Solidity interfaces using solface
  • Generate ABIs using extractABIs.sh

@zomglings
Copy link
Collaborator Author

Skipping TerminusControllerFacet and related code. That will be superseded by: #281

@zomglings
Added terminus-gogogo
33dee9c 
Removed all `TerminusController` related functionality (see PR for more
details): #334
@zomglings
Copy link
Collaborator Author

ITerminus interface is unchanged.

kellan-simiotics
kellan-simiotics approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@kellan-simiotics kellan-simiotics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Reran all contract tests to verify.

@zomglings zomglings merged commit 2c01527 into main Aug 21, 2023
@zomglings zomglings deleted the terminus-migration branch August 21, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellan-simiotics kellan-simiotics kellan-simiotics approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Terminus to this repo + some enhancements
2 participants
@zomglings @kellan-simiotics