Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: assign a random ID to File's without one during Create #405

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

adamdecaf
Copy link
Member

@adamdecaf adamdecaf commented Dec 12, 2018

Previously we were only reading out the FileHeader which meant any Batch objects weren't included in the stored file.

Issue: #401

@adamdecaf adamdecaf requested a review from bkmoovio December 12, 2018 20:42
@codecov-io
Copy link

codecov-io commented Dec 12, 2018

Codecov Report

Merging #405 into master will decrease coverage by 0.45%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
- Coverage   85.08%   84.62%   -0.46%     
==========================================
  Files         109      110       +1     
  Lines        6846     8879    +2033     
==========================================
+ Hits         5825     7514    +1689     
- Misses        729     1073     +344     
  Partials      292      292
Impacted Files Coverage Δ
server/service.go 81.17% <ø> (-4.16%) ⬇️
server/files.go 1.69% <0%> (-0.27%) ⬇️
server/common.go 100% <100%> (ø)
test/ach-adv-read/main.go 55.55% <0%> (-8.09%) ⬇️
test/ach-axt-read/main.go 57.14% <0%> (-8.08%) ⬇️
test/ach-ccd-read/main.go 57.14% <0%> (-8.08%) ⬇️
test/ach-iat-read/main.go 60% <0%> (-8%) ⬇️
test/ach-trc-read/main.go 47.82% <0%> (-7.73%) ⬇️
test/ach-trx-read/main.go 47.82% <0%> (-7.73%) ⬇️
test/ach-xck-read/main.go 47.82% <0%> (-7.73%) ⬇️
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ee93d...183c2e5. Read the comment docs.

@adamdecaf adamdecaf merged commit 7d54baf into moov-io:master Dec 12, 2018
@adamdecaf adamdecaf deleted the file-create-without-id branch December 12, 2018 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants