Wrap errors from external libraries to prevent leaking sensitive information #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #185 +/- ##
==========================================
+ Coverage 70.50% 70.91% +0.41%
==========================================
Files 37 38 +1
Lines 1773 1798 +25
==========================================
+ Hits 1250 1275 +25
- Misses 334 336 +2
+ Partials 189 187 -2 ☔ View full report in Codecov by Sentry. |
Dakinola892
approved these changes
Jul 20, 2022
alovak
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #103
Introduce a
SafeErrortype (credits to @alovak for the idea!) which is used to wrap around external errors, preventing the returned error message from displaying sensitive information, while still allowing errors to be matched.Use this new error type to wrap external errors in the
fieldandencodingpackages, as these operate on the potentially sensitive data.I considered also wrapping external errors in the
prefixandnetworkpackages, but since these only operate on the length part of the data, exposing their details should be okay (as long as the message is correctly formatted).