Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added max_search_results #49

Merged
merged 3 commits into from
Jun 12, 2020
Merged

added max_search_results #49

merged 3 commits into from
Jun 12, 2020

Conversation

ScuttleSE
Copy link
Contributor

This adds max_seach_results as a parameter for the configuration of the local-plugin

Defaults to 100.

Useful because there is no other way right now to get around the hard-coded limit of 100 results.

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #49 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   50.84%   50.91%   +0.06%     
==========================================
  Files           9        9              
  Lines         765      766       +1     
==========================================
+ Hits          389      390       +1     
  Misses        376      376              
Impacted Files Coverage Δ
mopidy_local/library.py 42.85% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be79bcb...655fd91. Read the comment docs.

@kingosticks
Copy link
Member

Can you please fix the failing test add also the new config option to the documentation in the README?

@ScuttleSE
Copy link
Contributor Author

Runs smoothly now

@kingosticks kingosticks merged commit 5e6d260 into mopidy:master Jun 12, 2020
@kingosticks
Copy link
Member

Thanks

@kingosticks kingosticks added this to the v3.2.0 milestone Jun 12, 2020
@kingosticks kingosticks linked an issue Jun 12, 2020 that may be closed by this pull request
@kingosticks kingosticks added the C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal label Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit of searchresults are hardcoded
2 participants