Fix/workaround auth changes #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workaround (fix?) was reported in mopidy#123
The "public" client id method was appearing to succeed but returning a None url and skipping the normal method.
|
I might need to fix some tests here |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we remove the client id request parameter (as reported in #123) things seem to start working again. The SC docs claim the OAuth token will expire after an hour but that does not seem to be the case.
Also fixed where the non-public client id method to obtain a stream link was never being called. Although weirdly this method isn't using our client id anymore and still seems to work... I'm not interesting enough in using SC to get into this much further.