-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for playlist management (v2) #287
base: main
Are you sure you want to change the base?
Commits on Nov 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 95c1031 - Browse repository at this point
Copy the full SHA 95c1031View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5333536 - Browse repository at this point
Copy the full SHA 5333536View commit details -
Added support for paging playlist edit calls
It also addresses the comments in mopidy#236
Configuration menu - View commit details
-
Copy full SHA for c23eda1 - Browse repository at this point
Copy the full SHA c23eda1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0acd636 - Browse repository at this point
Copy the full SHA 0acd636View commit details -
Configuration menu - View commit details
-
Copy full SHA for d449225 - Browse repository at this point
Copy the full SHA d449225View commit details -
fix SpotifyPlaylistsProvider.partitions() usage
- can't pass in sets, only lists - provide a useful default n parameter
Configuration menu - View commit details
-
Copy full SHA for 1dc0e7e - Browse repository at this point
Copy the full SHA 1dc0e7eView commit details
Commits on Nov 7, 2020
-
making playlist private, not just for the obvious reason, but also because our API client is not authorized for the playlist-modify-public scope (only playlist-modify-private).
Configuration menu - View commit details
-
Copy full SHA for 13e98bf - Browse repository at this point
Copy the full SHA 13e98bfView commit details
Commits on Nov 15, 2020
-
Don't invalidate whole cache on playlist modifications
not thoroughly tested yet
Configuration menu - View commit details
-
Copy full SHA for 2994325 - Browse repository at this point
Copy the full SHA 2994325View commit details -
Implement diff algorithm, API calls
Uses Myers' diff, extended to detect moved ranges. With the exception of non-consecutive deletes, this generates a near-optimal edit script.
Configuration menu - View commit details
-
Copy full SHA for 42a6506 - Browse repository at this point
Copy the full SHA 42a6506View commit details -
Mock up a Spotify API backend that supports editing playlists
To use the preexisting mopidy_album_mock the web translator had to be extended to parse release dates (only the year is supported, as that's what the test data requires).
Configuration menu - View commit details
-
Copy full SHA for ba0a616 - Browse repository at this point
Copy the full SHA ba0a616View commit details
Commits on Nov 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 46f2935 - Browse repository at this point
Copy the full SHA 46f2935View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9caa71 - Browse repository at this point
Copy the full SHA e9caa71View commit details -
Keep utils test coverage at 100%
op.__repr__ is useful for debugging only.
Configuration menu - View commit details
-
Copy full SHA for 4ec107c - Browse repository at this point
Copy the full SHA 4ec107cView commit details -
this won't ever fire, since getattr() will raise on error.
Configuration menu - View commit details
-
Copy full SHA for 74d405f - Browse repository at this point
Copy the full SHA 74d405fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6708ee - Browse repository at this point
Copy the full SHA d6708eeView commit details
Commits on Nov 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 525f420 - Browse repository at this point
Copy the full SHA 525f420View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8ce572 - Browse repository at this point
Copy the full SHA e8ce572View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4adc6f4 - Browse repository at this point
Copy the full SHA 4adc6f4View commit details
Commits on Nov 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4b3a3b4 - Browse repository at this point
Copy the full SHA 4b3a3b4View commit details -
Add some notes about the confusing part of delta_f/t
... and its accompanying tests.
Configuration menu - View commit details
-
Copy full SHA for 468a811 - Browse repository at this point
Copy the full SHA 468a811View commit details
Commits on Nov 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 8af448b - Browse repository at this point
Copy the full SHA 8af448bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b3c09d1 - Browse repository at this point
Copy the full SHA b3c09d1View commit details -
Move Spotify Web API specific stuff to web.py
note that these functions are not part of the SpotifyOAuthClient class, so the web_client_mock will use them, instead of a mocked version of them.
Configuration menu - View commit details
-
Copy full SHA for 6fd0a7b - Browse repository at this point
Copy the full SHA 6fd0a7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ec1c44 - Browse repository at this point
Copy the full SHA 3ec1c44View commit details -
Comment from @kingosticks: > Tracks might be currently unplayable if unavailable in the geo region > where the user is logged in (but may be playable from elsewhere and/or > in the future). These unplayable tracks will clutter the > queue/playlist listing and might be confusing to users when they try > to play them. But I don't see another way to avoid losing them when we > use save().
Configuration menu - View commit details
-
Copy full SHA for 6237b5c - Browse repository at this point
Copy the full SHA 6237b5cView commit details
Commits on Nov 29, 2020
-
Refuse outright if spotify:local tracks are present
Since the Spotify Web API does not support adding tracks, we can't make use of the 'replace' strategy. And removing local tracks by URL+position doesn't work either (according to some vague docs), so we'd have to rework not just the DELETE API call, but also delta counting and implement fetching of additional playlist metadata. further reading: https://community.spotify.com/t5/Spotify-for-Developers/API-Get-a-Playlist-s-Items-Incorrect-tracks/td-p/4990167 https://developer.spotify.com/documentation/general/guides/local-files-spotify-playlists/
Configuration menu - View commit details
-
Copy full SHA for 79317af - Browse repository at this point
Copy the full SHA 79317afView commit details
Commits on Dec 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 609795f - Browse repository at this point
Copy the full SHA 609795fView commit details
Commits on Jan 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 47c553f - Browse repository at this point
Copy the full SHA 47c553fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8c69f7 - Browse repository at this point
Copy the full SHA f8c69f7View commit details
Commits on Jan 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for fc11efe - Browse repository at this point
Copy the full SHA fc11efeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d596ed - Browse repository at this point
Copy the full SHA 0d596edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 400060e - Browse repository at this point
Copy the full SHA 400060eView commit details
Commits on Jan 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 50f1ab3 - Browse repository at this point
Copy the full SHA 50f1ab3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c0358a - Browse repository at this point
Copy the full SHA 1c0358aView commit details