-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of shared subscriptions #796
Merged
andsel
merged 19 commits into
moquette-io:main
from
andsel:feature/implement_shared_subscription
Dec 16, 2023
Merged
Initial implementation of shared subscriptions #796
andsel
merged 19 commits into
moquette-io:main
from
andsel:feature/implement_shared_subscription
Dec 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…criptionRequest instead of plain Subscription
…mposed arguments. Introduced specific wrapper class (SubscriptionRequest) to model only the phase of subscription
…irectory and selection on publish match
…opic doesn't receive messages
…e subscribed correctly respecting the read permission from the authorizator
Added test to verify the requirements and implemented.
…Publish messages, one for each shared group (aka Share name).
6 tasks
andsel
force-pushed
the
feature/implement_shared_subscription
branch
6 times, most recently
from
December 15, 2023 16:27
fec45d4
to
25a5d77
Compare
andsel
force-pushed
the
feature/implement_shared_subscription
branch
from
December 15, 2023 16:41
25a5d77
to
d21cd29
Compare
andsel
force-pushed
the
feature/implement_shared_subscription
branch
from
December 15, 2023 17:04
f2f7c5b
to
98abd7b
Compare
…0 when subscribed with QoS0, and after an upgradde of the shared subscription to QoS1, also the published message is reflected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Initial implementation of shared subscription subscribe and publish part.
What does this PR do?
Contains a series of updates to the broker internal structures to sustain shared subscription registering and dispatching of publish messages.
In CTrie's
CNode
add a separateshared subscriptions
data structure to contains the shared subscriptions list related to share name for a given topic filter. It's implemented as a map keyed by share name which maps to a list of shared subscriptions.Updated the
CTrie
's insertion method to use a data classSubscriptionRequest
to capture the shared and non shared subscription actions.Implemented test cases to cover the various MQTT spec requirements as integrations tests, and adapted utility classes (like the low level Client to permit the verification).
Why is it important/What is the impact to the user?
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases