Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide CountBy in net9+ #1020

Closed
viceroypenguin opened this issue Oct 23, 2023 · 1 comment · Fixed by #1092
Closed

Hide CountBy in net9+ #1020

viceroypenguin opened this issue Oct 23, 2023 · 1 comment · Fixed by #1092
Milestone
4.4.0

Comments

@viceroypenguin
Copy link
Contributor

net9.0 has added CountBy() overloads that overlap the MoreLinq versions. We should hide them in net9+. Similar to #749.

See: dotnet/runtime#91507
@atifaziz atifaziz added this to the vNext milestone Oct 23, 2023
@viceroypenguin viceroypenguin mentioned this issue Sep 24, 2024
Closed
@atifaziz atifaziz modified the milestones: vNext, 4.4.0 Dec 28, 2024
@atifaziz
Copy link
Member

Something to note is that the name for the key comparer parameter differs (keyComparer vs comparer) and while it may not present a binary compatibility issue, it will be a source compatibility one if someone decides to name the argument at the call site.

@atifaziz atifaziz mentioned this issue Dec 28, 2024
Merged
atifaziz added a commit that referenced this issue Dec 28, 2024
@atifaziz
Hide "CountBy" in .NET 9+
845294d 
This is squashed merge of PR #1092 that closes #1020.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.4.0
Development

Successfully merging a pull request may close this issue.

Hide CountBy in .NET 9+ atifaziz/MoreLINQ
2 participants
@atifaziz @viceroypenguin