Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate expressions argument to ToDataTable cannot be null #802

Closed
atifaziz opened this issue Mar 18, 2021 · 0 comments · Fixed by #1021
Closed

Validate expressions argument to ToDataTable cannot be null #802

atifaziz opened this issue Mar 18, 2021 · 0 comments · Fixed by #1021
Assignees
@atifaziz
Labels
breaking-change
Milestone
4.0.0

Comments

@atifaziz
Copy link
Member

atifaziz commented Mar 18, 2021 •
edited
Loading

Address the following to-do comment:

MoreLINQ/MoreLinq/ToDataTable.cs

Line 101 in 9d71dae

// TODO disallow null for "expressions" in next major update

This is to align with the non-nullability of the argument type.
@atifaziz atifaziz added this to the vNext milestone Mar 18, 2021
@atifaziz atifaziz changed the title Validate expressions argument to "ToDataTable" cannot be null Validate expressions argument to ToDataTable cannot be null Oct 23, 2023
@atifaziz atifaziz modified the milestones: vNext, 4.0 Oct 23, 2023
@atifaziz atifaziz self-assigned this Oct 23, 2023
@atifaziz atifaziz mentioned this issue Oct 23, 2023
Merged
atifaziz added a commit that referenced this issue Oct 23, 2023
@atifaziz
Validate "expressions" of "ToDataTable"
137564f 
This is a squashed merge of PR #1021 that fixes #802.
julienasp pushed a commit to julienasp/MoreLINQ that referenced this issue Nov 14, 2023
@atifaziz @julienasp
Validate "expressions" of "ToDataTable"
438d817 
This is a squashed merge of PR morelinq#1021 that fixes morelinq#802.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atifaziz atifaziz

Labels
breaking-change
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Validate expressions argument of ToDataTable atifaziz/MoreLINQ
1 participant
@atifaziz