Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable tests for hidden extensions on all targets #1009

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

atifaziz
Copy link
Member

@atifaziz atifaziz commented Jun 26, 2023

This PR re-enables tests for extensions hidden in PR #945. This not only helps recover the coverage (from 90.7% to 93.3%), requires less maintenance of conditionally compiled code, but also exercises those extensions that are still accessible via MoreLinq.Extensions.*Extension wrappers.

Coverage before:

Summary
  Parser: MultiReport (4x OpenCover)
  Assemblies: 1
  Classes: 20
  Files: 113
  Line coverage: 90.7%
  Covered lines: 3104
  Uncovered lines: 318
  Coverable lines: 3422
  Total lines: 15386
  Branch coverage: 87.4% (2097 of 2399)
  Covered branches: 2097
  Total branches: 2399
  Method coverage: 91.6% (482 of 526)
  Covered methods: 482
  Total methods: 526

MoreLinq                                    90.7%
  Delegating.Delegate                      100.0%
  Delegating.DelegatingDisposable           87.5%
  Delegating.DelegatingObserver<T>          90.9%
  MoreLinq.Assume                          100.0%
  MoreLinq.CollectionLike                   85.7%
  MoreLinq.CollectionLike<T>               100.0%
  MoreLinq.Collections.Dictionary<T1, T2>  100.0%
  MoreLinq.Debug                           100.0%
  MoreLinq.Disposable                        0.0%
  MoreLinq.EmptyArray<T>                   100.0%
  MoreLinq.Grouping<T1, T2>                 59.4%
  MoreLinq.ListLike                         88.8%
  MoreLinq.ListLike<T>                     100.0%
  MoreLinq.Lookup<T1, T2>                   58.8%
  MoreLinq.MoreEnumerable                   94.2%
  MoreLinq.PendNode<T>                       0.0%
  MoreLinq.Reactive.Observable             100.0%
  MoreLinq.Reactive.Subject<T>              81.5%
  MoreLinq.ReverseComparer<T>              100.0%
  MoreLinq.SequenceException                50.0%

Coverage after:

Summary
  Parser: MultiReport (4x OpenCover)
  Assemblies: 1
  Classes: 20
  Files: 113
  Line coverage: 93.3%
  Covered lines: 3196
  Uncovered lines: 226
  Coverable lines: 3422
  Total lines: 15386
  Branch coverage: 90% (2161 of 2399)
  Covered branches: 2161
  Total branches: 2399
  Method coverage: 94.1% (495 of 526)
  Covered methods: 495
  Total methods: 526

MoreLinq                                    93.3%
  Delegating.Delegate                      100.0%
  Delegating.DelegatingDisposable           87.5%
  Delegating.DelegatingObserver<T>          90.9%
  MoreLinq.Assume                          100.0%
  MoreLinq.CollectionLike                   85.7%
  MoreLinq.CollectionLike<T>               100.0%
  MoreLinq.Collections.Dictionary<T1, T2>  100.0%
  MoreLinq.Debug                           100.0%
  MoreLinq.Disposable                        0.0%
  MoreLinq.EmptyArray<T>                   100.0%
  MoreLinq.Grouping<T1, T2>                 59.4%
  MoreLinq.ListLike                         88.8%
  MoreLinq.ListLike<T>                     100.0%
  MoreLinq.Lookup<T1, T2>                   58.8%
  MoreLinq.MoreEnumerable                   95.1%
  MoreLinq.PendNode<T>                      98.4%
  MoreLinq.Reactive.Observable             100.0%
  MoreLinq.Reactive.Subject<T>              81.5%
  MoreLinq.ReverseComparer<T>              100.0%
  MoreLinq.SequenceException                50.0%

Coverage delta:

diff --git a/before.txt b/after.txt
index d3e601c2..61df92fd 100644
--- a/before.txt
+++ b/after.txt
@@ -3,19 +3,19 @@ Summary
   Assemblies: 1
   Classes: 20
   Files: 113
-  Line coverage: 90.7%
-  Covered lines: 3104
-  Uncovered lines: 318
+  Line coverage: 93.3%
+  Covered lines: 3196
+  Uncovered lines: 226
   Coverable lines: 3422
   Total lines: 15386
-  Branch coverage: 87.4% (2097 of 2399)
-  Covered branches: 2097
+  Branch coverage: 90% (2161 of 2399)
+  Covered branches: 2161
   Total branches: 2399
-  Method coverage: 91.6% (482 of 526)
-  Covered methods: 482
+  Method coverage: 94.1% (495 of 526)
+  Covered methods: 495
   Total methods: 526
 
-MoreLinq                                    90.7%
+MoreLinq                                    93.3%
   Delegating.Delegate                      100.0%
   Delegating.DelegatingDisposable           87.5%
   Delegating.DelegatingObserver<T>          90.9%
@@ -30,8 +30,8 @@ MoreLinq                                    90.7%
   MoreLinq.ListLike                         88.8%
   MoreLinq.ListLike<T>                     100.0%
   MoreLinq.Lookup<T1, T2>                   58.8%
-  MoreLinq.MoreEnumerable                   94.2%
-  MoreLinq.PendNode<T>                       0.0%
+  MoreLinq.MoreEnumerable                   95.1%
+  MoreLinq.PendNode<T>                      98.4%
   MoreLinq.Reactive.Observable             100.0%
   MoreLinq.Reactive.Subject<T>              81.5%
   MoreLinq.ReverseComparer<T>              100.0%

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #1009 (c5fca69) into master (d739f65) will increase coverage by 2.07%.
The diff coverage is n/a.

❗ Current head c5fca69 differs from pull request most recent head e98d632. Consider uploading reports for the commit e98d632 to get more accurate results

@@            Coverage Diff             @@
##           master    #1009      +/-   ##
==========================================
+ Coverage   90.50%   92.57%   +2.07%     
==========================================
  Files         113      113              
  Lines        3422     3422              
  Branches     1055     1055              
==========================================
+ Hits         3097     3168      +71     
+ Misses        263      191      -72     
- Partials       62       63       +1     

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atifaziz atifaziz merged commit e98d632 into morelinq:master Jun 26, 2023
@atifaziz atifaziz deleted the re-enable-tests branch June 26, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant