-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use .NET 8 SDK to add .NET 8 target #1041
Conversation
Conflicts resolved: - MoreLinq.Test/MemoizeTest.cs - MoreLinq.Test/MoreLinq.Test.csproj - MoreLinq.Test/SliceTest.cs - MoreLinq/PublicAPI/net8.0/PublicAPI.Shipped.txt - MoreLinq/PublicAPI/net8.0/PublicAPI.Unshipped.txt - MoreLinq/RandomSubset.cs - MoreLinq/SequenceException.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will read some more later.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1041 +/- ##
=======================================
Coverage 92.62% 92.62%
=======================================
Files 113 113
Lines 3419 3419
Branches 1055 1055
=======================================
Hits 3167 3167
Misses 189 189
Partials 63 63 ☔ View full report in Codecov by Sentry. |
a3b88be I thought about this too. I think I would qualify it as shipped, because even though there's no net8 version released, net8 consumers are consuming the net6 version which does have these methods. The important thing for the shipped/unshipped files is to have awareness via PR which things are added for the consumer in the next update. net8 consumers won't see these functions as new in net8, they'll just have net8 improvements. |
@viceroypenguin Technically speaking, there's no difference but it just seems more honest and less confusing (especially for newcomers and pre-releases) to say it's unshipped for now.
You might be saying the same thing, but I think it's more to avoid accidentally leaking something into the Public API. It could be eventually used for tacking too. |
This is a squashed merge of PR morelinq#1041. --------- Co-authored-by: Stuart Turner <stuart@turner-isageek.com>
This PR adds the .NET 8 target (requiring SDK upgrade to 8.0 too), primarily to address #1012.
This PR overlaps with #1039 from @viceroypenguin, which was done in parallel. Any differences will be consolidated here.