Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .NET 8 SDK to add .NET 8 target #1041

Merged
merged 11 commits into from
Nov 16, 2023
Merged

Use .NET 8 SDK to add .NET 8 target #1041

merged 11 commits into from
Nov 16, 2023

Conversation

atifaziz
Copy link
Member

@atifaziz atifaziz commented Nov 15, 2023

This PR adds the .NET 8 target (requiring SDK upgrade to 8.0 too), primarily to address #1012.

This PR overlaps with #1039 from @viceroypenguin, which was done in parallel. Any differences will be consolidated here.

atifaziz and others added 6 commits November 15, 2023 08:52
Conflicts resolved:

- MoreLinq.Test/MemoizeTest.cs
- MoreLinq.Test/MoreLinq.Test.csproj
- MoreLinq.Test/SliceTest.cs
- MoreLinq/PublicAPI/net8.0/PublicAPI.Shipped.txt
- MoreLinq/PublicAPI/net8.0/PublicAPI.Unshipped.txt
- MoreLinq/RandomSubset.cs
- MoreLinq/SequenceException.cs
@atifaziz atifaziz added this to the 4.1.0 milestone Nov 15, 2023
@atifaziz atifaziz changed the title Add .NET 8 target Use .NET 8 SDK to add .NET 8 target Nov 15, 2023
Copy link
Contributor

@viceroypenguin viceroypenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will read some more later.

MoreLinq.Test/SliceTest.cs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97dbe98) 92.62% compared to head (663a61c) 92.62%.

❗ Current head 663a61c differs from pull request most recent head a3b88be. Consider uploading reports for the commit a3b88be to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1041   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files         113      113           
  Lines        3419     3419           
  Branches     1055     1055           
=======================================
  Hits         3167     3167           
  Misses        189      189           
  Partials       63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atifaziz atifaziz marked this pull request as draft November 15, 2023 23:50
@atifaziz atifaziz marked this pull request as ready for review November 16, 2023 18:26
@viceroypenguin
Copy link
Contributor

a3b88be I thought about this too. I think I would qualify it as shipped, because even though there's no net8 version released, net8 consumers are consuming the net6 version which does have these methods. The important thing for the shipped/unshipped files is to have awareness via PR which things are added for the consumer in the next update. net8 consumers won't see these functions as new in net8, they'll just have net8 improvements.

@atifaziz
Copy link
Member Author

atifaziz commented Nov 16, 2023

@viceroypenguin Technically speaking, there's no difference but it just seems more honest and less confusing (especially for newcomers and pre-releases) to say it's unshipped for now.

The important thing for the shipped/unshipped files is to have awareness via PR which things are added for the consumer in the next update.

You might be saying the same thing, but I think it's more to avoid accidentally leaking something into the Public API. It could be eventually used for tacking too.

@atifaziz atifaziz merged commit 9a4ea61 into morelinq:master Nov 16, 2023
1 of 2 checks passed
@atifaziz atifaziz deleted the net8 branch November 16, 2023 22:04
julienasp pushed a commit to julienasp/MoreLINQ that referenced this pull request Nov 18, 2023
This is a squashed merge of PR morelinq#1041.
---------

Co-authored-by: Stuart Turner <stuart@turner-isageek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants