Refactor RandomSubset internals for DRY, removing closure
#1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceroypenguin
commented
Nov 18, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1049 +/- ##
==========================================
- Coverage 92.50% 92.50% -0.01%
==========================================
Files 112 112
Lines 3404 3401 -3
Branches 1056 1056
==========================================
- Hits 3149 3146 -3
Misses 189 189
Partials 66 66 ☔ View full report in Codecov by Sentry. |
atifaziz
approved these changes
Nov 19, 2023
atifaziz
changed the title
RandomSubsetImplRandomSubset for DRY, removing closure
atifaziz
changed the title
RandomSubset for DRY, removing closureRandomSubset internals for DRY, removing closure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the implementation of
RandomSubsetImplto remove the unnecessary closure and DRY the instantiation code.