Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch with lazy enumerables (issue #400) #402

Closed
wants to merge 15 commits into from

Conversation

leandromoh
Copy link
Collaborator

@leandromoh leandromoh commented Mar 3, 2018

implements the requested of Optimize Batch to return lazy enumerables.

As requested here, all batches are buffered in different lists. So when you move on to the next batch, the one before becomes fodder for GC.

@leandromoh leandromoh changed the title Batchlazy (issue #400) Batch with lazy enumerables (issue #400) Mar 5, 2018
@leandromoh
Copy link
Collaborator Author

@atifaziz @Arithmomaniac
What do you think?

@Arithmomaniac
Copy link
Contributor

I have my hands full, so unless @atifaziz asks me to do otherwise, I'm not going to review this.

@atifaziz
Copy link
Member

atifaziz commented Mar 6, 2018

@Arithmomaniac I've got my hands full here too so I doubted I'll get round to reviewing this any time soon. There's one more thing…we never decided in #400 that there is indeed a problem that needs addressing and what the solution would be so this PR jumps the gun for me. If @leandromoh is just sharing an experiment with an implementation here then that's fine but this isn't going to be a priority for me.

@Arithmomaniac Perhaps #400 should be closed seeing that no one has the time and that Batch isn't burning down the house for anyone? 😉

@Arithmomaniac
Copy link
Contributor

@atifaziz I'm fine with this, but we should have a tag for things that were closed due to lack of interest if we don't already.

@atifaziz
Copy link
Member

atifaziz commented Mar 7, 2018

@Arithmomaniac There's already the won't-fix label for that but honestly, a closed issue that's not been tagged as either an enhancement, a bug or a task is essentially something that's been abandoned. Perhaps won't-fix is too strong for #400 as I feel it doesn't have a problem statement?

@Arithmomaniac
Copy link
Contributor

Maybe "won't-implement"?

@leandromoh
Copy link
Collaborator Author

I cant see why close the issue If It was not resolved.

There is a lot of issues openned even without a PR. So why close this, that does?

@atifaziz
Copy link
Member

atifaziz commented Oct 29, 2019

Closing since #400 has been closed too.

@atifaziz atifaziz closed this Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants