Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable parallel building due to T4 for simplicity #779

Merged
merged 1 commit into from
Dec 27, 2020

Conversation

atifaziz
Copy link
Member

This is a follow-up PR from PR #776. It disables parallel builds for MoreLinq.csproj for overall simplicity with respect to observed corner cases. It does not seem to slow down building in a noticeable way, but goes a long way to simplify the T4 code generation integration into the project file by not requiring a separate and special mode of execution with -p:BuildInParallel=false.

@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #779 (2abc6a9) into master (4cf0359) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #779   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files         108      108           
  Lines        3473     3473           
  Branches      984      984           
=======================================
  Hits         3053     3053           
  Misses        272      272           
  Partials      148      148           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf0359...2abc6a9. Read the comment docs.

@atifaziz atifaziz merged commit 2abc6a9 into morelinq:master Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant