Fix "TrySingle" signature with honest nullable annotations #801
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a to-do comment pending since PR #582 that questioned whether we could be more honest with the signatures of
TrySingle
regardingT
beingnull
when cardinality isn't one. Starting with C# 9, it looks like we can finally address this with unconstrained type parameter annotations:This PR fixes the signatures to be more honest and removes the need for the use of the dammit (
!
) operator within the implementation body.We still can't express that
T
isn'tnull
when cardinality is one (e.g. through some of the helper attributes for the compiler) but the new annotations are far better than what was there before.