-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Pad*" signatures with more honest nullable annotations #804
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idle curiosity on NRT handling: I wonder if passing a Func<int, T>
will return an IEnumerable<T>
or IEnumerable<T?>
. Looks good regardless
Will return based on whatever
Almost. Had one of the overloads wrong but hopefully fixed with 58ca7f9. |
Without the |
Yes.
I'll admit I'm being sneaky with the compiler, but I am toying with the idea and wanted to throw it here to get reactions from reviewers so thank you for yours!
JIT should optimise
While it might seem extreme for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good w/ the explicit Defaultable<T>
. Definitely agree that it will JIT away, was more on the "why create it" aspect. If it works, then 🤷♂️
This PR adds to #803. Where a
TSource
is defaulted for padding, the signature now clearly saysTSource?
.