Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Allow copy-only mode #22

Merged
merged 1 commit into from
May 29, 2018
Merged

✨ Allow copy-only mode #22

merged 1 commit into from
May 29, 2018

Conversation

jayvdb
Copy link
Member

@jayvdb jayvdb commented May 29, 2018

closes #21

@codecov-io
Copy link

codecov-io commented May 29, 2018

Codecov Report

Merging #22 into master will decrease coverage by 0.08%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   98.85%   98.77%   -0.09%     
==========================================
  Files          27       27              
  Lines        1139     1143       +4     
==========================================
+ Hits         1126     1129       +3     
- Misses         13       14       +1
Impacted Files Coverage Δ
moban/main.py 100% <100%> (ø) ⬆️
moban/mobanfile.py 94.59% <88.88%> (-2.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a353b20...a9c7b97. Read the comment docs.

Copy link
Member Author

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A less intrusive approach would be to internally add a fake template target.

Performance isnt an issue for this very obscure use case.

@chfw chfw merged commit b224532 into moremoban:master May 29, 2018
@jayvdb jayvdb deleted the or-copy branch May 29, 2018 15:39
chfw added a commit that referenced this pull request May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants