-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: cleanup implementation (remove deprecated async task, share code between old/new architecture, prevent crashes on curson management) #752
Comments
@morenoh149 : in my refactoring I've seen that on android side there is a partial management of Android permission. |
@EnricoMazzu coud you share a link to the lines in question? If we can remove a dependency that would be a win |
Hi @morenoh149 [ContactsManager.java] (https://github.com/morenoh149/react-native-contacts/blob/v8.0.3/android/src/newarch/com/rt2zz/reactnativecontacts/ContactsManager.java) methods: I can work to handle permission directly in the module code (without delegate this task for android to the app and AndroidPermission module) |
@EnricoMazzu sounds good |
This issue is stale, please provide more information about the status |
Step of rewark:
NB: work on implementation , not on apis contract ->No breaking changes
I will submit a pull request in the next days
The text was updated successfully, but these errors were encountered: