Fix thumbnails not displaying

[bradbyte]

Fix issue #22 by adding .png to the tempfilePath. It can now be sourced directly in the <Image/> tag by the uri key.

[morenoh149]

couldn't you also append .png on the javascript side? does that not work?
pros and cons?

[bradbyte]

I just tried that in the app by appending .png to the uri... still no luck. That shouldn't work because the files are being saved as thumbimage_XXXX so changing the path in JS would cause it to look for a file called thumbimage_XXXX.png, which wouldn't exist. I guess for some reason it can't read the file without an extension? I'm not super familiar with xcode, but is there a reason to not add an extension to the temp image files?

Thanks,

[morenoh149]

Nope. Just trying to understand the code by asking a question.

[bradbyte]

No worries! :) it's really hard to find answers online related to this since the RN core API has changed.

I was able to troubleshoot this fix by downloading the App's data container from my device, and being able to see all of the thumbimage files in the tmp folder. Opening them on my mac revealed the picture was fine. Yet for some reason they wouldn't load in JS. I was just trying to see what I could do to make them recognize that they were indeed image files.. so I tried appending the .png prefix.

Most of the asset packaging docs out there now refer to requiring local files relative to the source code.... but these are temp files on the device itself. Maybe down the road someone will find a better, less hacky way to do this.

@rt2zz, thoughts?

Thanks!

[rt2zz]

This sounds reasonable. I cannot find anywhere the indicates that kABPersonImageFormatThumbnail is actually a png, @bradbumbalough can you confirm that the files are in fact png's?

Either way I will take this into master but not cut a new release until things are better tested/understood