incorrect if logic in Speller.replaceRunOnWords()?

[danielnaber]

This looks wrong, it uses getOutputConversionPairs() if it's empty, shouldn't it be the other way round?

morfologik-stemming/morfologik-speller/src/main/java/morfologik/speller/Speller.java

Lines 340 to 345 in dc8dde7

	if (!dictionaryMetadata.getOutputConversionPairs().isEmpty()) {
	candidates.add(firstCh + " " + original.subSequence(i, original.length()));
	} else {
	candidates.add(DictionaryLookup.applyReplacements(firstCh + " " + original.subSequence(i, original.length()),
	dictionaryMetadata.getOutputConversionPairs()).toString());
	}

I'm not sure if applyReplacements() makes sense at all. We've just checked that both parts are in the dictionary, should replacements still be applied? The if isn't tested, remove it and testRunonWords() still works.

Ping @milekpl, seems this was originally your code.

[danielnaber]

@jaumeortola Maybe you can comment on this?

[jaumeortola]

I think you are right. The 'if' can be removed and just do candidates.add( ). But I haven't done any test.
Is this used anywhere? Does it cause any error?

[danielnaber]

I found this when trying to develop a fix for languagetool-org/languagetool#731 (comment) and I just thought it's probably better to clean it up first.