Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DependencyConvergence checks to parent pom #78

Merged
merged 1 commit into from
Apr 7, 2016

Conversation

aldenquimby
Copy link
Contributor

This fixes a dependency convergence issue introduced via 3ada8d8.

Any projects that currently depend on morfologik 2.1.0 and have maven-enforcer dependency convergence enabled need to add a morfologik-stemming entry in dependencyManagement to deal with the conflict.

I came across this when upgrading my languagetool dependency from 3.1 to 3.3 - see languagetool-org/languagetool#342 (comment) for additional context.

I added a dependency convergence check to the morfologik parent so that I could test this change by running mvn validate. I'm happy to remove that, or move it, if you don't want to enforce dependency convergence.

@dweiss
Copy link
Member

dweiss commented Apr 5, 2016

Thanks for pointing this out -- this is in fact a bug, the whole dependency is a mistake (don't know why it ended up there).

@dweiss
Copy link
Member

dweiss commented Apr 5, 2016

Could you rebase your patch on top of the removed dependency section (just add dependency convergence checks). Also, this plugin should run only in verify phase, no need to do it all the time.

@dweiss dweiss changed the title Fix DependencyConvergence issue in morfologik-speller Add DependencyConvergence checks to parent pom Apr 5, 2016
@dweiss dweiss added this to the 2.1.1 milestone Apr 5, 2016
@dweiss dweiss self-assigned this Apr 5, 2016
@aldenquimby aldenquimby force-pushed the master branch 2 times, most recently from 1635938 to 008b901 Compare April 7, 2016 00:25
@aldenquimby
Copy link
Contributor Author

@dweiss thanks for the quick response here. I rebased and moved to verify phase - anything else I should do for this?

@dweiss
Copy link
Member

dweiss commented Apr 7, 2016

Nope, this looks good -- thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants