-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Non gvim compatibility #4
Comments
Great theme. But yea, wish there was one for the terminal |
for terminal users I suggest the CSApprox plugin. Though it's not the same colors it's quite a solution for the majority of vim's colorschemes |
@morhetz Loving it on MacVim, but sadly I don't use MacVim 99% of the time. :/ |
same question for me, hope this color scheme can have non GUI version |
This should be fixed with the latest commit f2efaec. I'll provide updated documentation and term-autodetection a little bit later. If your term doesn't handle italic text then it's displayed inverted. In this case you should put this string to vimrc before setting colorsheme: Also "let g:gruvbox_termcolors=16" will use base 16-color palette for most colors, which is handy if your term-theme uses gruvbox colors, and also it provides you more accurate result. This would be the recommended way to use gruvbox at term. See "Palette" section at colorscheme file for details. I think I'll keep this issue opened for a while. |
@morhetz Awesome, thanks! So for us to be able to use it on a terminal we would need to use a Gruvbox terminal theme correct? |
@greduan There is a third way, i didn't mentioned. If you use urxvt-256-xresources you could overload 256-palette instead of switching to 16 colors. E.g.: As I've already mentioned I'm going to update documentation soon. Do I recomend you to switch term colortheme to gruvbox and use g:gruvbox_termcolors=16 option? Sure. Do you have to? Nope, but colors wouldn't be that precise using default 256 palette. |
@morhetz Also damn you for being able to use Arch Linux. ;) Wish I could but this Mac makes it a royal pain in the ass. |
@greduan
I know, I know - I should put some term-detection and auto-disable italics if it's not rxvt. |
That can happen. Wow all right. Fixed that. I miss urxvt. :( Also what made you quit Arch? It is still my favorite distro of Linux, only problem is that it's practically impossible to use it on a Mac. At least within a reasonable time frame. |
@greduan As far as I can see you've decided to use 256-color palette. Would you mind testing this experimental script gist:6822769 in iTerm? It should overload 256-palette same way urxvt-256-xresources would do, but using ANSI-escape codes instead. UPD.: Could you please try it inside tmux and w/o tmux? If it doesn't help you could try replacing every "\e" with "\x1B" as pointed here. |
Well it doesn't give me any errors, whether I use Should I see any visible changes or is it just minor changes in the Vim theme? |
@greduan |
Oh yeah I notice that. It is so much prettier now. lol And yes it does work with tmux and without tmux. |
@greduan
|
All right. Yeah I added it to my .zshrc already. :) Perhaps it would be smart to have two versions of the file, one with |
@greduan |
I am using the |
Ok, thank you again, I'll add |
You're welcome. :) Thanks for making this awesome theme. :) |
Hmm seems to work in ubuntu as well now. When you said "Using 16-color palette from gruvbox terminal colorscheme" at #4 (comment) where do you suggest we set 16 color settings? |
@krzkrzkrz Those 16 colors are set by the theme your terminal app is using |
Manually changing each color palette in gnome terminal -> preference. Is there a better way? Plus hard to identify the colors you are suggesting. i.e. what is "grey"? There are a few shades of grey. Good job on the theme. I like it a lot. One other suggestion, would be to change the cursor background color when it is over a highlighted searched term. Does that make sense? For example. I search for "foo". It highlights all text with "foo". The background color it assigns it is yellow. If I move my cursor on top of any "foo" word. The cursor turns black, which makes it look like the cursor went away. |
@krzkrzkrz There is no better way AFAIK, unless you know how to edit the colorscheme file for your terminal directly. So until there's a theme someone makes using these colors this is the best way. :/ |
|
@greduan @morhetz And it seems like it needs a special sequence: printf_template="\ePtmux;\e\e]4;%d;rgb:%s\a\e" (which works) I could not make it work in screen though: the doc says "Esc P" should trigger bypassing (http://www.gnu.org/software/screen/manual/html_node/Control-Sequences.html) Here's the gruvbox script in question: https://github.com/morhetz/gruvbox/blob/master/gruvbox_256palette.sh |
This allows to change the scheme from within tmux. From the tmux CHANGES (1.5): * Support passing through escape sequences to the underlying terminal by using DCS with a "tmux;" prefix. Source: http://permalink.gmane.org/gmane.comp.terminal-emulators.tmux.user/1324 Ref: morhetz/gruvbox#4 (comment)
@blueyed |
Also use POSIX shell syntax: lighter and the script might be sourced. Ref: morhetz#4
@morhetz |
@blueyed |
FWIW: I've learnt that tmux should be able to handle this normally, per pane, and that only GNU screen needs these escape codes to be wrapped: https://github.com/chriskempson/base16-builder/pull/189 |
Also use POSIX shell syntax: lighter and the script might be sourced. Ref: morhetz#4
Hey :)
Thanks for this beautiful theme!! It would be great if I could use it in the Terminal as well ;)
best,
Dionysis
The text was updated successfully, but these errors were encountered: