Add Target Framework netstandard2.0 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for .NET Framework and .NET Core - Add Target Framework netstandard2.0 - Upgrade package DocumentFormat.OpenXml to 2.18.0 - Upgrade package Markdig to 0.33.0
marknn3
commented
Nov 23, 2023
| @@ -90,7 +90,7 @@ public void ForceCloseParagraph() | |||
| } | |||
| } | |||
|
|
|||
| public override DocxDocumentRenderer Render(MarkdownObject markdownObject) | |||
| public override object Render(MarkdownObject markdownObject) | |||
There was a problem hiding this comment.
Changed the return type to object for compatibility with .NET Framework and .NET Standard 2.0:
Error CS8830 '...runtime doesn't support covariant return types in overrides. Return type must be 'object' to match overridden member 'RendererBase.Render(MarkdownObject)'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for .NET Framework and .NET Core