Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transaction fee calculation issue #629

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Fix transaction fee calculation issue #629

merged 1 commit into from
Nov 5, 2024

Conversation

WorldDogs
Copy link
Contributor

  • Fixed blob fee calculation logic in Blob transaction type
  • Added judgment for weiAmt being nil to avoid potential null pointer exceptions

@WorldDogs
fix(tx-submitter): Fixed transaction fee calculation issue
f09a670 
- Fixed blob fee calculation logic in Blob transaction type
- Added judgment for weiAmt being nil to avoid potential null pointer exceptions
@WorldDogs WorldDogs requested a review from a team as a code owner November 5, 2024 07:19
@WorldDogs WorldDogs requested review from yunxu1 and removed request for a team November 5, 2024 07:19
@WorldDogs WorldDogs changed the title fix(tx-submitter): Fixed transaction fee calculation issue Fix transaction fee calculation issue Nov 5, 2024
@WorldDogs WorldDogs merged commit 677527c into main Nov 5, 2024
2 checks passed
@WorldDogs WorldDogs deleted the fix_calcfee branch November 5, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curryxbo curryxbo curryxbo approved these changes

@timtide timtide timtide approved these changes

@yunxu1 yunxu1 Awaiting requested review from yunxu1 yunxu1 is a code owner automatically assigned from morph-l2/security

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WorldDogs @timtide @curryxbo