Feat(tx-submitter): add rollup loss control functionality #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WorldDogs
commented
Nov 21, 2024
WorldDogs
commented
- Implement batch cache to store and retrieve rollup batches
- Add logic to calculate and compare transaction fees with collected L1 fees
- Introduce new configuration options for rollup loss control
- Update transaction submission process to include fee checks
- Add unit tests for new functionality
- Implement batch cache to store and retrieve rollup batches - Add logic to calculate and compare transaction fees with collected L1 fees - Introduce new configuration options for rollup loss control - Update transaction submission process to include fee checks - Add unit tests for new functionality
timtide
approved these changes
Nov 21, 2024
curryxbo
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.