Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transferRewards is a bad name #251

Closed
MathisGD opened this issue Oct 22, 2023 · 4 comments · Fixed by #278
Closed

transferRewards is a bad name #251

MathisGD opened this issue Oct 22, 2023 · 4 comments · Fixed by #278
Assignees
@Rubilmax

Comments

@MathisGD
Copy link
Contributor

MathisGD commented Oct 22, 2023 •
edited
Loading

Nothing in Morpho Blue nor Metamorpho enforces the rewards distribution mechanism that is envisioned. Plus nothing ensures that the tokens transferred are actually "rewards", but they could well be donations for example.

I propose transferAdditionnalTokens or transferVaultHoldings
@Jean-Grimal
Copy link
Contributor

I'm ok with transferVaultHoldings

@Rubilmax
Copy link
Contributor

Rubilmax commented Oct 23, 2023 •
edited
Loading

skim is also a standard name for this, but is expected only if we move idle to a dead blue market (transfer all the vault's balanceOf to the recipient)

@MerlinEgalite
Copy link
Contributor

I'm against transferVaultHoldings since it looks like we're transferring depositors' funds.

skim is indeed quite common, transferAdditionnalTokens is clear also. sweep is also common.

@MathisGD
Copy link
Contributor Author

MathisGD commented Oct 23, 2023 •
edited
Loading

exactly let's wait for #254 to be implemented

@MathisGD MathisGD mentioned this issue Oct 23, 2023
Merged
@MerlinEgalite MerlinEgalite linked a pull request Oct 27, 2023 that will close this issue
remove idle supply #260
Merged
@Rubilmax Rubilmax mentioned this issue Oct 30, 2023
Merged
@Rubilmax Rubilmax removed a link to a pull request Nov 3, 2023
remove idle supply #260
Merged
@Rubilmax Rubilmax self-assigned this Nov 3, 2023
@Rubilmax Rubilmax linked a pull request Nov 3, 2023 that will close this issue
refactor(metamorpho): rename rewards to skim #278
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rubilmax Rubilmax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(metamorpho): rename rewards to skim morpho-org/metamorpho
4 participants
@Rubilmax @MerlinEgalite @MathisGD @Jean-Grimal