remove idle supply #260
Merged
remove idle supply #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
MerlinEgalite
requested changes
Oct 24, 2023
Signed-off-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com>
Rubilmax
reviewed
Oct 27, 2023
MerlinEgalite
force-pushed
the
feat/remove-idle
branch
from
f21498c
to
586ed73
Compare
MerlinEgalite
approved these changes
Nov 10, 2023
|
The CI is failing though |
Rubilmax
force-pushed
the
feat/remove-idle
branch
from
a997930
to
210f943
Compare
QGarchery
reviewed
Nov 14, 2023
Jean-Grimal
approved these changes
Nov 14, 2023
MathisGD
commented
Nov 14, 2023
README.md
Outdated
| - The vault's asset as loan token. | ||
| - No collateral token (`address(0)`). | ||
| - An arbitrary IRM. | ||
| - No oracle (`address(0)`). |
There was a problem hiding this comment.
Suggested change
| - No oracle (`address(0)`). | |
| - An arbitrary oracle. |
There was a problem hiding this comment.
Can I still suggest address(0)? I think it's interesting to have at least the maximum nb of parameters standard for idle markets
There was a problem hiding this comment.
MerlinEgalite
approved these changes
Nov 15, 2023
QGarchery
requested changes
Nov 15, 2023
MerlinEgalite
approved these changes
Nov 15, 2023
QGarchery
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #254
Fixes #301