Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete testing suit #175

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Complete testing suit #175

merged 4 commits into from
Oct 10, 2023

Conversation

Jean-Grimal
Copy link
Contributor

I checked we are now at 100% coverage for external and public functions.

@openzeppelin-code
Copy link

openzeppelin-code bot commented Oct 9, 2023 •
edited
Loading

Complete testing suit

Generated at commit: fc22f6f1d1cf136634016797e5b6afb482f09dd2

🚨 Vulnerabilities Summary

Process Issues Results
Contract Inspector note
low
Total		 15
5
20
Dependency Checker Total 0

For more details view the full report in OpenZeppelin Code

MerlinEgalite
MerlinEgalite requested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you this change to that PR as well please?

test/forge/MarketTest.sol Outdated Show resolved Hide resolved
test/forge/ReallocateWithdrawTest.sol Outdated Show resolved Hide resolved
test/forge/MarketTest.sol Outdated Show resolved Hide resolved
test/forge/MarketTest.sol Show resolved Hide resolved
test/forge/ReallocateWithdrawTest.sol Show resolved Hide resolved
Rubilmax
Rubilmax approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assertion messages can be further simplified (the shorter the better to me, being specific enough still)

@MerlinEgalite MerlinEgalite merged commit e0514da into main Oct 10, 2023
@MerlinEgalite MerlinEgalite deleted the feat/add-queue-tests branch October 10, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rubilmax Rubilmax Rubilmax approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jean-Grimal @Rubilmax @MerlinEgalite