Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test conversion rate with fee #196

Merged
merged 11 commits into from
Oct 18, 2023
Merged

Test conversion rate with fee #196

merged 11 commits into from
Oct 18, 2023

Conversation

MerlinEgalite
Copy link
Contributor

Fixes #153

@openzeppelin-code
Copy link

openzeppelin-code bot commented Oct 12, 2023 •
edited
Loading

Test conversion rate with fee

Generated at commit: 7a557e184694c2092603eb845266f853c786106a

🚨 Vulnerabilities Summary

Process Issues Results
Contract Inspector note
low
critical
Total		 22
7
1
30
Dependency Checker Total 0

For more details view the full report in OpenZeppelin Code

@MerlinEgalite MerlinEgalite requested review from a team, Rubilmax and Jean-Grimal and removed request for a team October 12, 2023 15:14
@MerlinEgalite MerlinEgalite marked this pull request as ready for review October 13, 2023 12:28
@MerlinEgalite MerlinEgalite marked this pull request as draft October 13, 2023 12:28
@MerlinEgalite MerlinEgalite marked this pull request as ready for review October 13, 2023 12:29
Jean-Grimal
Jean-Grimal reviewed Oct 13, 2023
View reviewed changes
test/forge/FeeTest.sol Outdated Show resolved Hide resolved
Rubilmax
Rubilmax suggested changes Oct 16, 2023
View reviewed changes
test/forge/FeeTest.sol Outdated Show resolved Hide resolved
test/forge/FeeTest.sol Outdated Show resolved Hide resolved
test/forge/FeeTest.sol Outdated Show resolved Hide resolved
test/forge/helpers/BaseTest.sol Outdated Show resolved Hide resolved
Jean-Grimal
Jean-Grimal approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@Jean-Grimal Jean-Grimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't approve on Friday because I didn't see the borrow in FeeTest's setup (I see it now), so lgtm

Rubilmax
Rubilmax suggested changes Oct 18, 2023
View reviewed changes
test/forge/FeeTest.sol Outdated Show resolved Hide resolved
@MerlinEgalite MerlinEgalite merged commit 4061ee3 into main Oct 18, 2023
6 checks passed
@MerlinEgalite MerlinEgalite deleted the test/conversion-rate branch October 18, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test conversion rate functions with interest
3 participants
@MerlinEgalite @Rubilmax @Jean-Grimal