Review metamorpho simple refactor #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGarchery
commented
Oct 18, 2023
QGarchery
commented
Oct 18, 2023
QGarchery
commented
Oct 18, 2023
QGarchery
commented
Oct 18, 2023
QGarchery
commented
Oct 18, 2023
QGarchery
commented
Oct 18, 2023
QGarchery
requested review from
MathisGD,
a team,
Rubilmax,
MerlinEgalite and
Jean-Grimal
and removed request for
a team
Rubilmax
reviewed
Oct 18, 2023
MerlinEgalite
requested changes
Oct 18, 2023
There was a problem hiding this comment.
Thx!
I'd like to discuss the same topics as @Rubilmax + the refactor of the storage
Jean-Grimal
reviewed
Oct 18, 2023
MerlinEgalite
approved these changes
Oct 19, 2023
Jean-Grimal
approved these changes
Oct 19, 2023
Rubilmax
suggested changes
Oct 19, 2023
Rubilmax
approved these changes
Oct 19, 2023
MerlinEgalite
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits one by one to make sense of their commit message, or look for comments below explaining the refactors