Fix rounding in max deposit

[Jean-Grimal]

Fixes https://cantina.xyz/code/8409a0ce-6c21-4cc9-8ef2-bd77ce7425af/findings/963a0dbd-fcf0-4882-9d07-ac6711667cd8
Fixes https://cantina.xyz/code/8409a0ce-6c21-4cc9-8ef2-bd77ce7425af/findings/52649f43-6794-4046-888e-ebaaa7e3d0a4

[Rubilmax]

Ideally we should have a test for it
Hopefully it shouldn't be too difficult

[MerlinEgalite]

Shouldn't this issue be fixed as well: https://cantina.xyz/code/8409a0ce-6c21-4cc9-8ef2-bd77ce7425af/findings/52649f43-6794-4046-888e-ebaaa7e3d0a4?q=status%253Anew%252Cdisputed%252Crejected%252Cduplicate%252Cconfirmed%252Cacknowledged%252Cfixed ?

[adhusson]

The change in _maxDeposit reimplements MorphoBalancesLib.expectedSupplyAssets (rounding up), and the change in _supplyMorpho reimplements MetaMorpho. _accruedSupplyBalance (rounding up).

Not sure how to remember this but any future modification of those functions may have to be ported to these reimplementations.

[StErMi]

Like you have done for _supplyMorpho maybe would be good to also add a comment here. I know that this is more a "utility" function and not a "core" one like _supplyMorpho but it will be probably used very much by integrators.

Consider also adding it as a natspec @dev comment.

[StErMi]

I was worried about if (assets != 0) revert ErrorsLib.AllCapsReached(); but both _maxDeposit and _supplyMorpho adopt the same behavior, so it should be fine as long as users use maxDeposit if they want to be sure to not revert because they try to supply above the cap.

Note that because of the rounding up that overestimates what has been already supplied to Morpho, it will underestimate what you can supply (compared to the cap). This means that there's the possibility that the cap is never reachable (because of rounding)