acknowledge non idempotence of updateWithdrawQueue
#371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinEgalite
changed the title
updateWithdrawQueueupdateWithdrawQueue
MerlinEgalite
approved these changes
Dec 28, 2023
Merged
MerlinEgalite
requested review from
a team,
adhusson,
Rubilmax,
QGarchery and
Jean-Grimal
and removed request for
a team
Jean-Grimal
approved these changes
Dec 29, 2023
StErMi
reviewed
Dec 30, 2023
| @@ -159,6 +159,7 @@ interface IMetaMorphoBase { | |||
| /// market to be empty can be griefed by a front-run. To circumvent this, the allocator can simply bundle a | |||
| /// reallocation that withdraws max from this market with a call to `updateWithdrawQueue`. | |||
| /// @dev Warning: Removing a market with supply will decrease the fee accrued until the next deposit/withdrawal. | |||
| /// @dev Warning: updateWithdrawQueue is not idempotent. Submitting twice the same tx will change the queue twice. | |||
There was a problem hiding this comment.
Nitpick: updateWithdrawQueue here is not wrapped by ` but in the above comments it is.
There was a problem hiding this comment.
nitpicking goes brrrrr
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #316 (by acknowledging it)
discussion: https://morpholabs.slack.com/archives/C02N7CSP91C/p1703775229246109