Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(vault): only read totalAssets once #42

Merged
merged 1 commit into from
Sep 13, 2023
Merged

perf(vault): only read totalAssets once #42

merged 1 commit into from
Sep 13, 2023

Conversation

Rubilmax
Copy link
Contributor

@Rubilmax Rubilmax marked this pull request as ready for review September 12, 2023 12:33
Base automatically changed from fix/deposit-fee to test/fees September 12, 2023 14:34
MerlinEgalite
MerlinEgalite reviewed Sep 12, 2023
View reviewed changes
contracts/SupplyVault.sol Show resolved Hide resolved
contracts/SupplyVault.sol Show resolved Hide resolved
contracts/SupplyVault.sol Show resolved Hide resolved
contracts/SupplyVault.sol Show resolved Hide resolved
@Rubilmax
Copy link
Contributor Author

Rubilmax commented Sep 13, 2023 •
edited
Loading

Wait for the underlying branch to be merged before merging this one

@Rubilmax Rubilmax changed the base branch from test/fees to main September 13, 2023 12:54
@Rubilmax Rubilmax merged commit 0aa35b3 into main Sep 13, 2023
5 checks passed
@Rubilmax Rubilmax deleted the perf/total-assets branch September 13, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rubilmax @MerlinEgalite @Jean-Grimal