Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metamorpho): add no pending value error #96

Merged
merged 4 commits into from
Sep 21, 2023
Merged

feat(metamorpho): add no pending value error #96

merged 4 commits into from
Sep 21, 2023

Conversation

Rubilmax
Copy link
Contributor

@Rubilmax Rubilmax marked this pull request as ready for review September 20, 2023 14:21
@Rubilmax Rubilmax marked this pull request as draft September 20, 2023 14:42
@Rubilmax Rubilmax changed the base branch from main to feat/revocator September 20, 2023 15:52
@Rubilmax Rubilmax marked this pull request as ready for review September 20, 2023 16:03
Base automatically changed from feat/revocator to main September 21, 2023 06:50
MerlinEgalite
MerlinEgalite approved these changes Sep 21, 2023
View reviewed changes
test/forge/TimelockTest.sol Show resolved Hide resolved
@MerlinEgalite MerlinEgalite merged commit 2251c0a into main Sep 21, 2023
5 of 6 checks passed
@MerlinEgalite MerlinEgalite deleted the feat/no-pending-value-error branch September 21, 2023 06:54
@MerlinEgalite MerlinEgalite mentioned this pull request Sep 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"timelock expiration exceeded" is unclear when no value is pending
3 participants
@Rubilmax @MerlinEgalite @Jean-Grimal