Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we accrue interest on collateral adjustments? #44

Closed
MerlinEgalite opened this issue Jul 5, 2023 · 6 comments · Fixed by #52
Closed

Should we accrue interest on collateral adjustments? #44

MerlinEgalite opened this issue Jul 5, 2023 · 6 comments · Fixed by #52
Assignees
Labels

Comments

@MerlinEgalite
Copy link
Contributor

Adding or withdrawing collateral does change the utilization rate so accrueing interest is not necessary from what I understand

@MathisGD
Copy link
Contributor

MathisGD commented Jul 5, 2023

It is necessary for withdrawCollateral because you need it for the health check.

But for supplying it is useless, nice catch ! Let's open a PR (nb: I'm in favor of keeping a comment for that).

@MathisGD
Copy link
Contributor

MathisGD commented Jul 5, 2023

NB: interests need to be accrued when either:

  • utilisation change (because it changes the rate) or
  • you need to know the latest balance to do something (eg health check)

@MerlinEgalite MerlinEgalite self-assigned this Jul 5, 2023
@MerlinEgalite
Copy link
Contributor Author

Assigned myself to the issue but waiting for the others do give their thoughts

@MathisGD
Copy link
Contributor

MathisGD commented Jul 5, 2023

I think that you can go there is no real tradeoff here

@MathisGD MathisGD linked a pull request Jul 5, 2023 that will close this issue
@Rubilmax
Copy link
Collaborator

Rubilmax commented Jul 5, 2023

No because it's not required

@MathisGD
Copy link
Contributor

MathisGD commented Jul 5, 2023

for supplyCollateral, not withdrawCollateral*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants