Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove accrue interest supplycollat #52

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Remove accrue interest supplycollat #52

merged 3 commits into from
Jul 6, 2023

Conversation

MerlinEgalite
Copy link
Contributor

It's not breaking tests so I think we're missing some tests (which is normal at this stage)

@MathisGD
Copy link
Contributor

MathisGD commented Jul 5, 2023

It's not breaking tests so I think we're missing some tests (which is normal at this stage)

but at the same time, this accrueInterests was literally useless (but yes we miss a lot of coverage)

@MathisGD MathisGD linked an issue Jul 5, 2023 that may be closed by this pull request
Should we accrue interest on collateral adjustments? #44
Closed
MathisGD
MathisGD requested changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good catch ! As told here, I would prefer to have a little comment replacing the "call", to explain why we don't need to do it.

makcandrov
makcandrov previously approved these changes Jul 5, 2023
View reviewed changes
MathisGD
MathisGD reviewed Jul 5, 2023
View reviewed changes
src/Blue.sol Show resolved Hide resolved
QGarchery
QGarchery previously approved these changes Jul 5, 2023
View reviewed changes
pakim249CAL
pakim249CAL previously approved these changes Jul 5, 2023
View reviewed changes
@MerlinEgalite MerlinEgalite dismissed stale reviews from pakim249CAL, QGarchery, and makcandrov via 9b9ed18 July 5, 2023 17:28
@MerlinEgalite MerlinEgalite merged commit 91e050d into dev Jul 6, 2023
@MerlinEgalite MerlinEgalite deleted the perf/remove-accrue-interest-supplycollat branch July 6, 2023 12:40
@MathisGD MathisGD mentioned this pull request Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QGarchery QGarchery QGarchery approved these changes

@makcandrov makcandrov makcandrov approved these changes

@MathisGD MathisGD MathisGD approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

@pakim249CAL pakim249CAL Awaiting requested review from pakim249CAL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we accrue interest on collateral adjustments?
6 participants
@MerlinEgalite @MathisGD @Rubilmax @QGarchery @pakim249CAL @makcandrov